Skip to content

[Dashboard] Feature: Default analytics range to 30 days and save preference #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

[Dashboard] Feature: Default analytics range to 30 days and save preference #7039

merged 1 commit into from
May 13, 2025

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 13, 2025 •
edited by pr-codex bot
Loading

  • Change default range to last 30 days for all analytics views
  • Add localStorage persistence for user's selected range preference
  • Add proper error handling with invalid duration ID
  • Fix separator key warning by adding unique keys

🤖 Generated with Claude Code

PR-Codex overview

This PR enhances the PayAnalyticsFilter component with improved handling of date ranges and local storage. It introduces a new defaultRange parameter, updates error messaging, and modifies the sidebar to highlight the "Universal Bridge" feature.

Detailed summary

  • Added defaultRange parameter with value "last-30" in getUniversalBridgeFiltersFromSearchParams.
  • Modified error message in date-range-selector for invalid duration IDs.
  • Updated SidebarSeparator to include a unique key prop.
  • Enhanced PayAnalyticsFilter to load and save date ranges from local storage.
  • Updated label for "Universal Bridge" in ProjectSidebarLayout to include a badge.
  • Implemented local storage functionality to persist selected date ranges and intervals.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl @claude
[TOOL-4489] Default analytics range to 30 days and save preference
d1ecd62 
- Change default range to last 30 days for all analytics views
- Add localStorage persistence for user's selected range preference
- Add proper error handling with invalid duration ID
- Fix separator key warning by adding unique keys

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
@gregfromstl gregfromstl requested review from a team as code owners May 13, 2025 22:16
@linear
Copy link

linear bot commented May 13, 2025

TOOL-4489 Default Analytics Range to 30 Days and Save Preference

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2025

⚠️ No Changeset found

Latest commit: d1ecd62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 10:23pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 13, 2025 10:23pm
login ⬜️ Skipped (Inspect) May 13, 2025 10:23pm
thirdweb_playground ⬜️ Skipped (Inspect) May 13, 2025 10:23pm
wallet-ui ⬜️ Skipped (Inspect) May 13, 2025 10:23pm

@graphite-app
Copy link
Contributor

graphite-app bot commented May 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 13, 2025
@codecov
Copy link

codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (1c31a1e) to head (d1ecd62).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7039   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files         909      909           
  Lines       58396    58396           
  Branches     4035     4035           
=======================================
  Hits        32056    32056           
  Misses      26235    26235           
  Partials      105      105
Flag Coverage Δ
packages 54.89% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 136 ms (+282.44% 🔺) 1.3 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 197 ms (+59.09% 🔺) 4.1 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 52 ms (+1408.13% 🔺) 166 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 18 ms (+1167.71% 🔺) 28 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 64 ms (+896.56% 🔺) 455 ms

@gregfromstl gregfromstl merged commit fb4c190 into main May 13, 2025
24 checks passed
@gregfromstl gregfromstl deleted the greg/tool-4489-default-analytics-range-to-30-days-and-save-preference branch May 13, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gregfromstl gregfromstl

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregfromstl